blackmwk commented on code in PR #2453:
URL: https://github.com/apache/iceberg-rust/pull/2453#discussion_r3361356088
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -505,12 +505,81 @@ impl SnapshotRetention {
#[cfg(test)]
mod tests {
use std::collections::HashMap;
+ use std::sync::Arc;
+ use bytes::Bytes;
use chrono::{TimeZone, Utc};
- use crate::spec::TableMetadata;
+ use crate::encryption::kms::{KeyManagementClient,
MemoryKeyManagementClient};
+ use crate::encryption::{EncryptionManager, StandardKeyMetadata};
+ use crate::io::FileIO;
+ use crate::spec::manifest_list::{ManifestList, ManifestListWriter};
use crate::spec::snapshot::_serde::SnapshotV1;
use crate::spec::snapshot::{Operation, Snapshot, Summary};
+ use crate::spec::{ManifestListReader, SnapshotRef, TableMetadata,
TableMetadataRef};
+
+ const ENCRYPTION_TEST_V3_METADATA: &str = r#"{
Review Comment:
We put such table metadata in testdata dir in other tests, I think we should
also follow this convention in this test.
##########
crates/iceberg/src/table.rs:
##########
@@ -330,9 +366,54 @@ impl StaticTable {
}
}
+/// If the table metadata sets the `encryption.key-id` property, build an
+/// [`EncryptionManager`] for the table.
+///
+/// Returns `Ok(None)` if the property is not set. Returns an error if the
+/// property is set but no [`KeyManagementClient`] was provided.
+fn maybe_configure_encryption(
Review Comment:
I prefer to move this `EncryptionManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
