xanderbailey commented on code in PR #2541:
URL: https://github.com/apache/iceberg-rust/pull/2541#discussion_r3332549618
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -90,6 +90,41 @@ impl ManifestList {
}
}
+/// A manifest list reader that encapsulates the logic for loading and parsing
a [`ManifestList`]
+/// from a snapshot.
+pub struct ManifestListReader<'a> {
Review Comment:
The reason I went for this is because the reader is very short lived, you
always call load on it right away to the lifetime is very short. I appreciate
the clones are cheap but maybe not necessary?
I can update to show what cloning looks like so you can see the difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
