blackmwk commented on code in PR #2541:
URL: https://github.com/apache/iceberg-rust/pull/2541#discussion_r3340827067
##########
crates/iceberg/src/catalog/utils.rs:
##########
@@ -36,18 +36,16 @@ const DELETE_CONCURRENCY: usize = 10;
/// Data files within manifests are only deleted if the `gc.enabled` table
/// property is `true` (the default), to avoid corrupting other tables that
/// may share the same data files.
-pub async fn drop_table_data(
- io: &FileIO,
- metadata: &TableMetadata,
- metadata_location: Option<&str>,
-) -> Result<()> {
+pub async fn drop_table_data(table_info: Table) -> Result<()> {
Review Comment:
```suggestion
pub(crate) async fn drop_table_data(table_info: &Table) -> Result<()> {
```
We should mark this crate private and accepts table ref only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
