blackmwk commented on code in PR #2541:
URL: https://github.com/apache/iceberg-rust/pull/2541#discussion_r3333806772
##########
crates/iceberg/src/catalog/utils.rs:
##########
@@ -47,7 +47,9 @@ pub async fn drop_table_data(
// Load all manifest lists concurrently
let results: Vec<_> =
futures::future::try_join_all(metadata.snapshots().map(|snapshot|
async {
- let manifest_list = snapshot.load_manifest_list(io,
metadata).await?;
+ let manifest_list = ManifestListReader::new(snapshot, io, metadata)
Review Comment:
Yes, and we should make this method crate private, it should not be called
by user directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
