alexandrefimov commented on code in PR #16614:
URL: https://github.com/apache/iceberg/pull/16614#discussion_r3340861159
##########
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##########
@@ -60,15 +62,29 @@ public class BaseDeleteLoader implements DeleteLoader {
private final Function<DeleteFile, InputFile> loadInputFile;
private final ExecutorService workerPool;
+ private final Map<String, String> readProperties;
public BaseDeleteLoader(Function<DeleteFile, InputFile> loadInputFile) {
this(loadInputFile, ThreadPools.getDeleteWorkerPool());
}
+ public BaseDeleteLoader(
Review Comment:
Small source-compatibility question: adding this overload makes existing
source calls like `new BaseDeleteLoader(loadInputFile, null)` ambiguous with
the existing `(Function, ExecutorService)` overload. This PR had to update the
JMH callers for that reason.
Since `BaseDeleteLoader` is public in `iceberg-data`, would it be better to
avoid this two-arg overload, for example by keeping only the three-arg variant
for callers that need read properties? That would keep the read-properties
propagation while avoiding a source-compat break for existing two-arg callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
