venkateshwaracholan commented on code in PR #16614:
URL: https://github.com/apache/iceberg/pull/16614#discussion_r3341129781
##########
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##########
@@ -60,15 +62,29 @@ public class BaseDeleteLoader implements DeleteLoader {
private final Function<DeleteFile, InputFile> loadInputFile;
private final ExecutorService workerPool;
+ private final Map<String, String> readProperties;
public BaseDeleteLoader(Function<DeleteFile, InputFile> loadInputFile) {
this(loadInputFile, ThreadPools.getDeleteWorkerPool());
}
+ public BaseDeleteLoader(
Review Comment:
Good point. I removed the `(Function<DeleteFile, InputFile>, Map<String,
String>)` overload and updated the new call sites to use the existing
worker-pool constructor plus read properties. This keeps the read-properties
propagation while avoiding ambiguity for existing callers using
`(Function<DeleteFile, InputFile>, ExecutorService)` with `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
