venkateshwaracholan commented on code in PR #16614:
URL: https://github.com/apache/iceberg/pull/16614#discussion_r3385619590
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1459,32 +1461,8 @@ public <D> CloseableIterable<D> build() {
if (batchedReaderFunc != null
|| batchedReaderFuncWithSchema != null
|| readerFunction != null) {
- ParquetReadOptions.Builder optionsBuilder;
- if (file instanceof HadoopInputFile) {
- // remove read properties already set that may conflict with this
read
- Configuration conf = new Configuration(((HadoopInputFile)
file).getConf());
- for (String property : READ_PROPERTIES_TO_REMOVE) {
- conf.unset(property);
- }
- optionsBuilder = HadoopReadOptions.builder(conf);
- } else {
- optionsBuilder = ParquetReadOptions.builder(new
PlainParquetConfiguration());
- }
-
- for (Map.Entry<String, String> entry : properties.entrySet()) {
- optionsBuilder.set(entry.getKey(), entry.getValue());
- }
-
- if (start != null) {
- optionsBuilder.withRange(start, start + length);
- }
-
- if (fileDecryptionProperties != null) {
- optionsBuilder.withDecryption(fileDecryptionProperties);
- }
-
- optionsBuilder.withUseHadoopVectoredIo(true);
- ParquetReadOptions options = optionsBuilder.build();
+ ParquetReadOptions options =
Review Comment:
Thanks, good catch. I inlined the read-options construction back into
ReadBuilder.build() so the diff focuses on the actual behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
