blackmwk commented on code in PR #2568:
URL: https://github.com/apache/iceberg-rust/pull/2568#discussion_r3341016533
##########
crates/iceberg/src/spec/manifest/writer.rs:
##########
@@ -52,14 +53,16 @@ pub struct ManifestWriterBuilder {
impl ManifestWriterBuilder {
/// Create a new builder.
pub fn new(
- output: OutputFile,
+ writer: Box<dyn FileWrite>,
Review Comment:
We don't need to this breaking api change, instead, we could add a new
method to accept encrypted output file, and these two methods share same
function which accepts FileWriter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
