xanderbailey commented on code in PR #2568:
URL: https://github.com/apache/iceberg-rust/pull/2568#discussion_r3348139222
##########
crates/iceberg/src/spec/manifest/writer.rs:
##########
@@ -186,14 +221,16 @@ pub struct ManifestWriter {
impl ManifestWriter {
/// Create a new manifest writer.
pub(crate) fn new(
- output: OutputFile,
+ writer_future: WriterFuture,
+ location: String,
Review Comment:
This is pub(crate) so I think it's okay to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
