blackmwk commented on code in PR #2568:
URL: https://github.com/apache/iceberg-rust/pull/2568#discussion_r3354956050
##########
crates/iceberg/src/spec/manifest/writer.rs:
##########
@@ -40,9 +43,12 @@ use crate::{Error, ErrorKind};
/// with the actual snapshot ID before it is committed.
const UNASSIGNED_SNAPSHOT_ID: i64 = -1;
+type WriterFuture = Pin<Box<dyn Future<Output = Result<Box<dyn FileWrite>>> +
Send>>;
Review Comment:
In fact I prefer to change to new method to async, but I think it's fine for
now, let's see in future if we could eliminate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
