Copilot commented on code in PR #1158:
URL: https://github.com/apache/iceberg-go/pull/1158#discussion_r3375764190
##########
catalog/hadoop/hadoop.go:
##########
@@ -474,22 +477,22 @@ func (c *Catalog) CommitTable(ctx context.Context, ident
table.Identifier, reqs
compression := updated.Properties().Get(table.MetadataCompressionKey,
table.MetadataCompressionDefault)
if err := internal.WriteTableMetadata(updated, icebergio.LocalFS{},
tempPath, compression); err != nil {
Review Comment:
CommitTable still writes new table metadata using a hard-coded
`icebergio.LocalFS{}` instead of the catalog's configured `c.filesystem`. This
breaks the intended filesystem abstraction (and can leave temp files behind or
write to the wrong backend once `Catalog.filesystem` is made configurable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
