C-Loftus commented on PR #1158: URL: https://github.com/apache/iceberg-go/pull/1158#issuecomment-4622318329
Thank you very much for the review @tanmayrauth! I appreciate it. I believe I have addressed your feedback now. Happy to iterate on anything else if you wish. 1. Documented which `fs.` errors each method in the `io` file needs to fulfill 2. Switched from a hardcoded `localfs` to the catalog interface. 3. Changed the `writefile` file permissions to your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
