rambleraptor commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3358569273
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/InternalRowConverter.java:
##########
@@ -80,6 +80,9 @@ private static Object convert(Type type, Object value) {
case STRING -> UTF8String.fromString((String) value);
case UUID -> UTF8String.fromString(value.toString());
case FIXED, BINARY -> {
+ if (value instanceof byte[] bytes) {
+ yield bytes;
+ }
Review Comment:
I was having some issues with the Spark tests and this seemed to be the best
way to fix it. Let me find a better way of handling this.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/InternalRowConverter.java:
##########
@@ -80,6 +80,9 @@ private static Object convert(Type type, Object value) {
case STRING -> UTF8String.fromString((String) value);
case UUID -> UTF8String.fromString(value.toString());
case FIXED, BINARY -> {
+ if (value instanceof byte[] bytes) {
+ yield bytes;
+ }
Review Comment:
I was having some issues with the Spark tests and this seemed to be the best
way to fix it. Let me find a better way of handling this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
