rambleraptor commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3358866588
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -130,6 +130,99 @@ protected boolean supportsBatchReads() {
@TempDir private File tableDir;
+ protected boolean supportsTime() {
+ return true;
+ }
+
+ protected boolean supportsTimestampNano() {
+ return true;
+ }
+
+ protected boolean supportsVariant() {
+ return true;
+ }
+
+ protected boolean supportsUnknown() {
+ return true;
+ }
Review Comment:
Yeah, I'm fine getting rid of them. They may not be always true in the
future, but we can add them back in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
