wombatu-kun commented on code in PR #16235:
URL: https://github.com/apache/iceberg/pull/16235#discussion_r3361967870
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java:
##########
@@ -587,4 +589,137 @@ public void testChunkedEncodingDisabled() {
.as("chunked encoding should be disabled when explicitly set to false")
.isFalse();
}
+
+ @Test
+ public void testApplyMetricsPublisherConfigurationWithFactoryMethod() {
Review Comment:
Each of the new tests applies `applyMetricsPublisherConfiguration` to a bare
`S3Client.builder()` in isolation, so they pass even when the method replaces
(rather than augments) the override config in the real client chain. Add a test
that applies `applyRetryConfigurations` (or `applyUserAgentConfigurations`)
first, then `applyMetricsPublisherConfiguration`, and asserts both the prior
setting (`retryPolicy` / `USER_AGENT_PREFIX`) and the metric publisher survive,
so the override-config preservation cannot silently regress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
