wombatu-kun commented on code in PR #16235:
URL: https://github.com/apache/iceberg/pull/16235#discussion_r3366531542
##########
aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java:
##########
@@ -76,6 +77,7 @@ public S3AsyncClient s3Async() {
.applyMutation(awsClientProperties::applyClientCredentialConfigurations)
.applyMutation(awsClientProperties::applyLegacyMd5Plugin)
.applyMutation(s3FileIOProperties::applyEndpointConfigurations)
+ .applyMutation(s3FileIOProperties::applyMetricsPublisherConfiguration)
Review Comment:
This wires the publisher onto the standard async builder, but `s3Async()`
returns early via `crtBuilder()` (line 67) when `s3.crt.enabled` is set, and
`S3CrtAsyncClientBuilder` exposes no metric-publisher method at all. A user who
combines `s3.metrics-publisher-impl` with `s3.crt.enabled` gets no async S3
metrics and no error. Worth a one-line note in the aws.md section that the
CRT-based async client does not honor a custom MetricPublisher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
