wgtmac commented on code in PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3363757766
##########
src/iceberg/catalog/rest/meson.build:
##########
@@ -40,17 +41,27 @@ cpr_needs_static = (
)
cpr_dep = dependency('cpr', static: cpr_needs_static)
+iceberg_rest_sources += files('auth/sigv4_auth_manager.cc')
iceberg_rest_build_deps = [iceberg_dep, cpr_dep]
+iceberg_rest_compile_defs = []
+
+sigv4_opt = get_option('sigv4')
+aws_sdk_core_dep = dependency('aws-cpp-sdk-core', required: sigv4_opt)
Review Comment:
This exposes SigV4 in Meson, but the dependency is only a system
aws-cpp-sdk-core lookup. Since Meson does not provide the same AWS SDK
resolution/vendor path as CMake and CI does not exercise a Meson SigV4 build,
this gives users a support signal that is not actually verified. I think we
should either add complete Meson dependency support and CI coverage, or leave
this feature unsupported in Meson for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
