plusplusjiajia commented on code in PR #616: URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3394439852
########## cmake_modules/IcebergThirdpartyToolchain.cmake: ########## @@ -539,3 +539,26 @@ endif() if(ICEBERG_BUILD_REST) resolve_cpr_dependency() endif() + +# ---------------------------------------------------------------------- +# AWS SDK for C++ + +function(resolve_aws_sdk_dependency) + find_package(AWSSDK REQUIRED COMPONENTS core) Review Comment: @wgtmac S3+SigV4 together is supported with a single SDK instance: with both ON, `ICEBERG_AWSSDK_SOURCE` defaults to BUNDLED, so SigV4 links Arrow's bundled `aws-cpp-sdk-core` (one copy, no ODR), and `BUNDLED` without S3 is rejected at configure time. The "AWS (S3 + SigV4)" CI job builds exactly this combination and is green on this PR. The workflow comment you quoted was stale (it described an older SYSTEM-based design) — fixed in the latest push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
