anoopj commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3368505189
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -351,12 +361,14 @@ static TrackedFileStruct createFullTrackedFile() {
FileFormat.PARQUET,
newPartition(7, "music"),
100L,
- 1024L);
+ 1024L,
+ WRITER_FORMAT_VERSION_V4);
file.set(6, 0);
file.set(9, 1);
file.set(10, dv);
file.set(12, ByteBuffer.wrap(new byte[] {1, 2, 3}));
file.set(13, ImmutableList.of(50L));
+ file.set(15, WRITER_FORMAT_VERSION_V4);
Review Comment:
Seems redundant as we are passing it through constructor?
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -49,6 +49,9 @@ interface TrackedFile {
Types.NestedField FILE_SIZE_IN_BYTES =
Types.NestedField.required(
104, "file_size_in_bytes", Types.LongType.get(), "Total file size in
bytes");
+ Types.NestedField WRITER_FORMAT_VERSION =
+ Types.NestedField.required(
Review Comment:
I believe this is optional per the proposal doc. An alternative is to it
required - ie require the table upgrades to populate it. Probably worth a
discussion
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -301,10 +313,10 @@ protected <T> void internalSet(int pos, T value) {
this.fileFormat = FileFormat.fromString(value.toString());
break;
case 4:
- this.recordCount = (Long) value;
+ this.recordCount = (long) value;
Review Comment:
Why did we change this? seems unrelated to the goal of this PR anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
