gaborkaszab commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3368869668
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -351,12 +361,14 @@ static TrackedFileStruct createFullTrackedFile() {
FileFormat.PARQUET,
newPartition(7, "music"),
100L,
- 1024L);
+ 1024L,
+ WRITER_FORMAT_VERSION_V4);
file.set(6, 0);
file.set(9, 1);
file.set(10, dv);
file.set(12, ByteBuffer.wrap(new byte[] {1, 2, 3}));
file.set(13, ImmutableList.of(50L));
+ file.set(15, WRITER_FORMAT_VERSION_V4);
Review Comment:
You're right. Let's see where the optional vs required conversation goes. If
it's optional, I'll remove it from the constructor, if it's required this step
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
