rambleraptor commented on PR #3454: URL: https://github.com/apache/iceberg-python/pull/3454#issuecomment-4674529725
I did some digging on what methods we might lose in the process of doing this. There's a handful of them that won't fully work since they call directly to a Cython method. .count(), .index(), reversed(), .copy(), and the `+` operator are the list that I have. You can still convert this to a proper list with `list()`, so we still have something that works. The original question was should we return iterators or should we return a PaginatedList? We didn't want to break the API, so PaginatedList was the answer. This feels ridiculous to ask, but could you implement these missing methods? I don't know if we'll ever be able to give ourselves a full list for confidence, but this will get us pretty close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
