stark256-spec commented on PR #3454: URL: https://github.com/apache/iceberg-python/pull/3454#issuecomment-4639200713
Addressed all four comments in e2bb799: - **Move type to typedef**: `PaginationList` is now in `pyiceberg/typedef.py` alongside the project's other core types. `pyiceberg/utils/pagination.py` is deleted. - **TypeAliasType**: Added `_PageFetchResult: TypeAlias = tuple[list[Identifier], str | None]` at module level in `rest/__init__.py`; all three `_fetch_page` signatures now use it. - **Test classes**: Flattened `TestPaginationList*` into top-level functions matching the style in the rest of the test suite. - **pre-commit config**: Reverted the D105/D418 additions. The root issue was that `@overload` stubs for `__getitem__` are magic methods with no docstring (D105), and you can't add a docstring to an `@overload` stub (D418). Fixed with `# noqa: D105` inline on those two stubs instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
