stark256-spec commented on PR #3454:
URL: https://github.com/apache/iceberg-python/pull/3454#issuecomment-4638878503
`PaginationList` has `@overload` stubs for `__getitem__` (two signatures —
one for `SupportsIndex`, one for `slice`). Those stubs are magic methods with
no docstring, which makes pydocstyle fire D105 ("Missing docstring in magic
method"). Adding a docstring to an `@overload` stub isn't an option either —
that triggers D418. Ended up suppressing both globally to break the deadlock.
Happy to revert this and drop `# noqa: D105` on just those two stub lines
instead — keeps the global config clean. Will do that in the next push along
with the other feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
