singhpk234 commented on PR #16768: URL: https://github.com/apache/iceberg/pull/16768#issuecomment-4737997777
@chenwyi2 seems like its explictly calls iterator close https://github.com/StarRocks/starrocks/pull/68678/changes#diff-6c25423f964e0e7910311e2cb6fba148f1def8754ce9e8a292e1c906ec3f14c2R1129 seems like starrocks is already calling the iterator close... i believe closing iterator is correct thing to do . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
