rdblue commented on a change in pull request #1946:
URL: https://github.com/apache/iceberg/pull/1946#discussion_r545556519
##########
File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
##########
@@ -123,7 +127,7 @@ public WriteBuilder named(String newName) {
return this;
}
- public WriteBuilder createWriterFunc(Function<Schema, DatumWriter<?>>
writerFunction) {
+ public WriteBuilder createWriterFunc(Function<Schema,
MetricsAwareDatumWriter<?>> writerFunction) {
Review comment:
This is going to break existing uses of `createWriterFunc` in projects
that build on Iceberg. I think this should keep the old parameter and just
check whether the implementation is `MetricsAwareDatumWriter` in the appender
to return metrics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
