rdblue commented on a change in pull request #1946:
URL: https://github.com/apache/iceberg/pull/1946#discussion_r546142313
##########
File path: api/src/main/java/org/apache/iceberg/FieldMetrics.java
##########
@@ -30,15 +28,15 @@
private final long valueCount;
private final long nullValueCount;
private final long nanValueCount;
- private final ByteBuffer lowerBound;
- private final ByteBuffer upperBound;
+ private final Object lowerBound;
+ private final Object upperBound;
Review comment:
I guess I was thinking that truncation would happen when `FieldMetrics`
is constructed, in the leaf writers. If that's not the case, then I think it
makes sense to do the conversion later.
If the conversion happens later, then I think this class should be
parameterized. I never like to have classes that track just `Object`. We should
at least guarantee that both lower and upper bounds are the same type, for
example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
