yyanyy commented on a change in pull request #1946:
URL: https://github.com/apache/iceberg/pull/1946#discussion_r546085953
##########
File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
##########
@@ -123,7 +127,7 @@ public WriteBuilder named(String newName) {
return this;
}
- public WriteBuilder createWriterFunc(Function<Schema, DatumWriter<?>>
writerFunction) {
+ public WriteBuilder createWriterFunc(Function<Schema,
MetricsAwareDatumWriter<?>> writerFunction) {
Review comment:
Sounds good, I didn't think of the case where people have their own
implementation of these interfaces so I totally missed this. Will update and
keep in mind!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
