nastra commented on code in PR #16864:
URL: https://github.com/apache/iceberg/pull/16864#discussion_r3459191565
##########
jmh.gradle:
##########
@@ -86,3 +86,26 @@ configure(jmhProjects) {
tasks.jmh.finalizedBy tasks.jmhReport
}
+
+project(':iceberg-core') {
+ dependencies {
+ // Aliyun OSS
+ jmhImplementation project(':iceberg-aliyun')
Review Comment:
I'm not sure about pulling all of these dependencies into core, even if it's
just for running a JMH benchmark. aliyun & s3 won't be the only ones and people
will most likely also want to test GCS & ADSL. Maybe having a separate gradle
module is the better approach, but we should bring this up on the mailing list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
