liuliquan-marshal commented on code in PR #16864:
URL: https://github.com/apache/iceberg/pull/16864#discussion_r3486421886


##########
jmh.gradle:
##########
@@ -86,3 +86,26 @@ configure(jmhProjects) {
 
   tasks.jmh.finalizedBy tasks.jmhReport
 }
+
+project(':iceberg-core') {
+  dependencies {
+    // Aliyun OSS
+    jmhImplementation project(':iceberg-aliyun')

Review Comment:
   I achieved the minimal approach in 336b66b7324537ca2a31b988db675759ea359b4a. 
   Could you take a look? If agreed, I will bring up seperate module discussion 
on the mailing list. If not, I can revert this commit(it's independent). 
   Thanks for reviewing again!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to