liuliquan-marshal commented on code in PR #16864:
URL: https://github.com/apache/iceberg/pull/16864#discussion_r3465072189
##########
jmh.gradle:
##########
@@ -86,3 +86,26 @@ configure(jmhProjects) {
tasks.jmh.finalizedBy tasks.jmhReport
}
+
+project(':iceberg-core') {
+ dependencies {
+ // Aliyun OSS
+ jmhImplementation project(':iceberg-aliyun')
Review Comment:
Thanks for the feedback. I agree that pulling cloud dependencies into core
isn't ideal.
How about we remove all the cloud storage dependencies from jmh.gradle
entirely?The benchmark would default to HadoopFileIO on local disk (zero
external dependencies), and users who want to test S3/OSS/GCS can add the
relevant JARs via -cp at runtime. For example, `java -cp
"iceberg-core-1.10.0-jmh.jar:libs/*"`.
What do you think? Maybe we could go with this minimal approach for now and
bring up seperate module discussion on the mailing list as a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
