wgtmac commented on code in PR #780:
URL: https://github.com/apache/iceberg-cpp/pull/780#discussion_r3475447528
##########
src/iceberg/CMakeLists.txt:
##########
@@ -45,11 +45,11 @@ set(ICEBERG_SOURCES
file_writer.cc
inspect/history_table.cc
inspect/metadata_table.cc
+ inspect/row_builder_internal.cc
Review Comment:
We can just name it to `row_builder.cc` because `_internal` suffix is used
for marking header files that do not need to be installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
