WZhuo commented on code in PR #780:
URL: https://github.com/apache/iceberg-cpp/pull/780#discussion_r3490083331
##########
src/iceberg/CMakeLists.txt:
##########
@@ -45,11 +45,11 @@ set(ICEBERG_SOURCES
file_writer.cc
inspect/history_table.cc
inspect/metadata_table.cc
+ inspect/row_builder_internal.cc
Review Comment:
Renamed to arrow_row_builder.cc -- internal suffix removed from .cc.
##########
src/iceberg/inspect/row_builder_internal.h:
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+/// \file iceberg/inspect/row_builder_internal.h
Review Comment:
Moved to core level as arrow_row_builder_internal.h / arrow_row_builder.cc.
ArrowRowBuilder now has two Make overloads: Make(const Schema&) for Iceberg
callers and Make(const ArrowSchema*) for lower-level callers like
position_delete_writer and manifest_adapter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
