WZhuo commented on PR #780: URL: https://github.com/apache/iceberg-cpp/pull/780#issuecomment-4830171272
Thanks for the thorough review. All three points addressed: 1. ArrowRowBuilder is now a single RAII class (merged the two classes), moved to core level, with `Make(const Schema&)` and `Make(const ArrowSchema*)` overloads so both metadata tables and lower-level code like position_delete_writer/manifest_adapter can use it. 2. Append* helpers are free functions alongside ArrowRowBuilder: null, int (int32/int64/timestamp), boolean, string, and string_map. 3. The lifecycle is properly guarded: `ArrowArrayGuard` right after `InitFromSchema`, `Release()` after `StartAppending` succeeds. Also added `Release()` to `ArrowArrayGuard` for other call sites to reuse this pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
