sungwy commented on code in PR #16822:
URL: https://github.com/apache/iceberg/pull/16822#discussion_r3499285334
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1123,6 +1120,34 @@ class RemoteSignResult(BaseModel):
headers: MultiValuedMap
+class RemoteSigningConfig(BaseModel):
+ """
+ Configuration for the remote signer client.
+ When present, clients SHOULD use this structure instead of the deprecated
`signer.uri` and
+ `signer.endpoint` properties in the `config` map.
+
+ """
+
+ base_uri: str = Field(
+ ...,
+ alias='base-uri',
+ description='The base URI of the signing service as perceived by the
client, incorporating X-Forwarded-* headers set by proxies. When present, takes
precedence over the deprecated `signer.uri` config property.\n',
Review Comment:
nit: this is now always required, so this wording works better imho
```suggestion
description='The base URI of the signing service as perceived by the
client, incorporating X-Forwarded-* headers set by proxies. Takes precedence
over the deprecated `signer.uri` config property.\n',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
