danielcweeks commented on code in PR #16822:
URL: https://github.com/apache/iceberg/pull/16822#discussion_r3508870451
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3680,9 +3680,16 @@ components:
## Remote Signing
- If remote signing for a specific storage provider is enabled, clients
must respect the following configurations when creating a remote signer client:
- - `signer.endpoint`: the remote signer endpoint. Required. Can either
be a relative path (to be resolved against `signer.uri`) or an absolute URI.
- - `signer.uri`: the base URI to resolve `signer.endpoint` against.
Optional. Only meaningful if `signer.endpoint` is a relative path. Defaults to
the catalog's base URI if not set.
+ If remote signing for a specific storage provider is enabled, the
server SHOULD use the `remote-signing-config`
+ field to communicate all signer client settings. When the
`remote-signing-config` field is present, clients
+ SHOULD take it into account.
+
+ For backward compatibility, the following `config` properties are
still supported but **DEPRECATED**:
Review Comment:
```suggestion
For backward compatibility, the following `config` properties are
still supported but **DEPRECATED** and should not be used by clients able to
consume the remote signing configuration:
```
The new config should fully override the deprecated behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
