sungwy commented on code in PR #16822:
URL: https://github.com/apache/iceberg/pull/16822#discussion_r3507783193
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -5247,6 +5256,27 @@ components:
headers:
$ref: '#/components/schemas/MultiValuedMap'
+ RemoteSigningConfig:
+ description: Configuration for the remote signer client.
Review Comment:
Could we add a note here, that if we use this RemoteSigningConfig, it should
takes precedence over the deprecated configs `signer.endpoint` and `signer.uri`?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -5247,6 +5256,27 @@ components:
headers:
$ref: '#/components/schemas/MultiValuedMap'
+ RemoteSigningConfig:
+ description: Configuration for the remote signer client.
+ type: object
+ required:
+ - base-uri
+ - endpoint-path
Review Comment:
remove required fields
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
