kinolaev commented on PR #17196: URL: https://github.com/apache/iceberg/pull/17196#issuecomment-4980697183
> But do we know any Iceberg engine path or downstream code that relies on the converted type being LongType? I saw this more as missing support for the logical type than an established contract While I agree that this is more of a missing feature, I would prefer not to make any assumptions about public API users. In a sense, even a missing feature in a public API is an established contract) I've updated the PR. `TypeToSchema` (Iceberg -> Avro) no longer sets `adjust-to-utc` when `legacyTimestampMapping=false`. I made this decision because a user must switch `SchemaToType` to `legacyTimestampMapping=false` first anyway to be able to convert `local-timestamp-*`. Once `SchemaToType` is switched, I see no reason to add `adjust-to-utc=true` after switching `TypeToSchema`. This change is reflected in the updated test. Iceberg-specific and Avro-native timestamp conversions are now covered. Thanks for the review, @AnatolyPopov ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
