RussellSpitzer commented on code in PR #17196:
URL: https://github.com/apache/iceberg/pull/17196#discussion_r3590867198
##########
core/src/main/java/org/apache/iceberg/avro/SchemaToType.java:
##########
@@ -177,6 +179,7 @@ public Type variant(Schema variant, Type metadataType, Type
valueType) {
return Types.VariantType.get();
}
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
Review Comment:
I don't think we need to supress the warning here. We can just extract the
timestamp logic out into it's own helper if required after removing the !legacy
checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
