kinolaev commented on code in PR #17196:
URL: https://github.com/apache/iceberg/pull/17196#discussion_r3590875282
##########
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##########
@@ -43,30 +43,55 @@ abstract class TypeToSchema extends
TypeUtil.SchemaVisitor<Schema> {
private static final Schema TIME_SCHEMA =
LogicalTypes.timeMicros().addToSchema(Schema.create(Schema.Type.LONG));
private static final Schema TIMESTAMP_SCHEMA =
-
LogicalTypes.timestampMicros().addToSchema(Schema.create(Schema.Type.LONG));
+
LogicalTypes.localTimestampMicros().addToSchema(Schema.create(Schema.Type.LONG));
private static final Schema TIMESTAMPTZ_SCHEMA =
LogicalTypes.timestampMicros().addToSchema(Schema.create(Schema.Type.LONG));
private static final Schema TIMESTAMP_NANO_SCHEMA =
-
LogicalTypes.timestampNanos().addToSchema(Schema.create(Schema.Type.LONG));
+
LogicalTypes.localTimestampNanos().addToSchema(Schema.create(Schema.Type.LONG));
private static final Schema TIMESTAMPTZ_NANO_SCHEMA =
LogicalTypes.timestampNanos().addToSchema(Schema.create(Schema.Type.LONG));
private static final Schema STRING_SCHEMA =
Schema.create(Schema.Type.STRING);
private static final Schema UUID_SCHEMA =
LogicalTypes.uuid().addToSchema(Schema.createFixed("uuid_fixed", null,
null, 16));
private static final Schema BINARY_SCHEMA = Schema.create(Schema.Type.BYTES);
+ private static final Schema LEGACY_TIMESTAMP_SCHEMA =
Review Comment:
As you said, just a stylistic choice) I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
