RussellSpitzer commented on code in PR #17196:
URL: https://github.com/apache/iceberg/pull/17196#discussion_r3596287180
##########
core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java:
##########
@@ -56,37 +56,75 @@ private AvroSchemaUtil() {}
private static final Schema.Type RECORD = Schema.Type.RECORD;
public static Schema convert(org.apache.iceberg.Schema schema, String
tableName) {
- return convert(schema, ImmutableMap.of(schema.asStruct(), tableName));
+ return convert(schema, tableName, true);
+ }
+
+ public static Schema convert(
Review Comment:
Let's start a general dev list thread. My gut instinct here is no, we don't
want to keep annotating this method with legacy flags because we don't actually
want to support that behavior for outside consumers. If you use this method and
we see an Iceberg type we know, we should get the right Iceberg type.
For precedent though you can check out
https://github.com/apache/iceberg/pull/12455
Where we similarly added recognition for new types (timestamp 9) which
previously would have fell through and become Long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
