kinolaev commented on code in PR #17196:
URL: https://github.com/apache/iceberg/pull/17196#discussion_r3591185497
##########
core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java:
##########
@@ -56,37 +56,75 @@ private AvroSchemaUtil() {}
private static final Schema.Type RECORD = Schema.Type.RECORD;
public static Schema convert(org.apache.iceberg.Schema schema, String
tableName) {
- return convert(schema, ImmutableMap.of(schema.asStruct(), tableName));
+ return convert(schema, tableName, true);
+ }
+
+ public static Schema convert(
Review Comment:
> boolean legacy =
!"local-timestamp".equals(config.get(AVRO_TIMESTAMP_ENCODING));
schema = AvroSchemaUtil.convert(icebergSchema, name, legacy); // internal
call, not public
I'd like to use `AvroSchemaUtil.convert` in my own project to convert
external Avro data and write it into Iceberg, like in this example
https://iceberg.apache.org/docs/latest/flink-writes/#write-with-avro-genericrecord.
Not to add Avro data files to an Iceberg table. So I'd like to have a public
method that supports `local-timestamp-*` and converts `timestamp-*` without
`adjust-to-utc` property to `timestamptz(_ns)`. So for me a table property is
not an option.
@RussellSpitzer , is adding a public method still a possibility we can
consider?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
