kinolaev commented on PR #17196:
URL: https://github.com/apache/iceberg/pull/17196#issuecomment-4993098785
I've dropped the condition for `local-timestamp-*` types, updated the tests,
and addressed style-related issues.
All checks have passed. It looks like enabling `local-timestamp-*` type
support in `AvroSchemaUtil` doesn't break `DataReader`, `PlannedDataReader` and
`DataWriter`. Can we keep this PR scoped to the `AvroSchemaUtil` class?
The main question remains: do we want to introduce public methods on
`AvroSchemaUtil` that:
1. convert Avro `timestamp-*` to Iceberg `timestamptz` when the
`adjust-to-utc` property is missing
2. convert Iceberg `timestamptz(_ns)` to Avro `timestamp-*` without the
`adjust-to-utc` property
3. convert Iceberg `timestamp(_ns)` to `local-timestamp-*`?
Personally, I'm only interested in ingesting Avro encoded records from Kafka
using Flink, similar to [the official
example](https://iceberg.apache.org/docs/latest/flink-writes/#write-with-avro-genericrecord).
So, even if no one adds support for Avro native timestamps to `DataReader`,
`PlannedDataReader` and `DataWriter`, the changes in this PR are still useful
on their own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
