zakariya-s commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3613066051
##########
crates/iceberg/src/catalog/metadata_location.rs:
##########
@@ -83,7 +84,7 @@ impl MetadataLocation {
/// Updates the metadata location with compression settings from the new
metadata.
pub fn with_new_metadata(&self, new_metadata: &TableMetadata) -> Self {
Self {
- table_location: self.table_location.clone(),
+ location: self.location.clone(),
Review Comment:
Funny you mention this, I initially did change it to honor the metadata path
here too
(https://github.com/apache/iceberg-rust/pull/2776#discussion_r3554734723,
https://github.com/apache/iceberg-rust/pull/2776#discussion_r3574070729) but we
ended up splitting it. I'm happy to add this back though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
