CTTY commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3617897317
##########
crates/iceberg/src/catalog/metadata_location.rs:
##########
@@ -83,7 +84,7 @@ impl MetadataLocation {
/// Updates the metadata location with compression settings from the new
metadata.
pub fn with_new_metadata(&self, new_metadata: &TableMetadata) -> Self {
Self {
- table_location: self.table_location.clone(),
+ location: self.location.clone(),
Review Comment:
Thanks for the context! I'd prefer fixing it here so we always use the
metadata location from the current metadata
If you think the change would be too big then let's leave TODO comments and
create a tracking issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
