zakariya-s commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3608942647
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -364,6 +364,33 @@ impl TableMetadata {
&self.properties
}
+ /// Returns the default metadata directory for a table location: the
`metadata`
+ /// subdirectory under `table_location`. Used when `write.metadata.path`
is not set.
+ pub fn default_metadata_dir(table_location: &str) -> String {
Review Comment:
Ah, also a note that we use `DEFAULT_DATA_DIR ` for the data dir, but
`METADATA_FOLDER_NAME` for the metadata dir
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -364,6 +364,33 @@ impl TableMetadata {
&self.properties
}
+ /// Returns the default metadata directory for a table location: the
`metadata`
+ /// subdirectory under `table_location`. Used when `write.metadata.path`
is not set.
+ pub fn default_metadata_dir(table_location: &str) -> String {
Review Comment:
Ah, also a note that we use `DEFAULT_DATA_DIR` for the data dir, but
`METADATA_FOLDER_NAME` for the metadata dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
