rdblue commented on a change in pull request #1920:
URL: https://github.com/apache/iceberg/pull/1920#discussion_r551461764
##########
File path: core/src/main/java/org/apache/iceberg/BaseTable.java
##########
@@ -30,13 +32,12 @@
* <p>
* This can be extended by providing a {@link TableOperations} to the
constructor.
*/
-public class BaseTable implements Table, HasTableOperations {
- private final TableOperations ops;
- private final String name;
+public class BaseTable implements Table, HasTableOperations, Serializable {
+ private transient TableOperations ops;
+ private transient String name;
Review comment:
Okay, after reading the `StaticTable`, I see what you're doing. But I
don't think that it is a good idea for this to make its fields transient. Can
we use a `readResolve` method to create a `BaseTable` directly instead of
having a `StaticTable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
