rdblue commented on a change in pull request #1920:
URL: https://github.com/apache/iceberg/pull/1920#discussion_r551462609
##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -85,6 +87,14 @@ public ConfigBuilder(Configuration conf) {
}
public Configuration conf() {
+ // Store the io and the current snapshot of the table in the
configuration which are needed for the split
+ // generation
+ Table table = Catalogs.loadTable(conf);
+
+ // The FileIO serializes the configuration and we might end up
recursively serializing the objects.
+ // To avoid this unset the value before serialization and set it again
in the next line.
+ conf.unset(InputFormatConfig.FILE_IO);
+ conf.set(InputFormatConfig.FILE_IO,
SerializationUtil.serializeToBase64(table.io()));
Review comment:
Shouldn't everything use the `FileIO` from the table instead of from the
config?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
