pvary commented on a change in pull request #1920:
URL: https://github.com/apache/iceberg/pull/1920#discussion_r551792187
##########
File path: core/src/main/java/org/apache/iceberg/BaseTable.java
##########
@@ -30,13 +32,12 @@
* <p>
* This can be extended by providing a {@link TableOperations} to the
constructor.
*/
-public class BaseTable implements Table, HasTableOperations {
- private final TableOperations ops;
- private final String name;
+public class BaseTable implements Table, HasTableOperations, Serializable {
+ private transient TableOperations ops;
+ private transient String name;
Review comment:
I was toying with implementing the `readResolve` too. I decided against
it because I thought it is more explicit to return a `StaticTable` object after
deserialization instead of returning a `BaseTable` where the `ops` are
`StaticTableOperations` and this way changing the behavior of the deserialized
object, but hiding the details.
Solved this by adding comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
