rdblue commented on a change in pull request #2001:
URL: https://github.com/apache/iceberg/pull/2001#discussion_r551624274
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
##########
@@ -124,10 +125,20 @@ public Metrics metrics() {
return ParquetUtil.footerMetrics(writer.getFooter(), model.metrics(),
metricsConfig);
}
+ /**
+ * Returns the number of bytes written by this writer.
+ * NOTE: call {@link ParquetWriter#close()})} prior this method to get the
exact number of bytes.
+ *
+ * @return the number of bytes written by this writer.
Review comment:
This isn't quite accurate. It is the number of bytes written only after
the writer is closed. How about `@return length of the file produced by this
writer, approximate until after closed`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
