rdblue commented on a change in pull request #2001:
URL: https://github.com/apache/iceberg/pull/2001#discussion_r552117580
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
##########
@@ -124,10 +125,20 @@ public Metrics metrics() {
return ParquetUtil.footerMetrics(writer.getFooter(), model.metrics(),
metricsConfig);
}
+ /**
+ * Returns the approximate length of the output file produced by this writer.
+ * <p>
+ * Prior to calling {@link ParquetWriter#close}, the result is approximate.
After calling close, the length is
+ * exact.
Review comment:
This needs a `@return` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
